Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeyboardManager] Added option for exact match shortcut #36000

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mantaionut
Copy link
Contributor

Summary of the Pull Request

Added option for exact match for a shortcut. If exact match is checked then the shortcut will only be replaced if no other keys are also pressed.

PR Checklist

Detailed Description of the Pull Request / Additional comments

The exact match key is in the select keys window below the Allow Chords checkbox.
I also removed ShortcutSecondKeyOfChordSettingName from begin saved and loaded in json since its redundant since secondKey is already set in SetKeyCodes in constructor.

Validation Steps Performed

  1. Open Keyboard Manager
  2. Create a shortcut and set it to exact match
  3. Check that the shortcut only gets triggered if no other keys are pressed.

This comment has been minimized.

@crutkas
Copy link
Member

crutkas commented Nov 20, 2024

@mantaionut you have to accept the CLA

@mantaionut
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In for .88 Needs-Review This Pull Request awaits the review of a maintainer.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants