Security and Compliance | Added new resource device tenant policy. #5256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntRule # Conflicts: # CHANGELOG.md
Modules/Microsoft365DSC/Examples/Resources/SCDeviceTenantPolicy/3-Remove.ps1
Show resolved
Hide resolved
|
Looks like you are missing the stub for the Remove-DeviceTenantPolicy cmdlet. |
|
@NikCharlebois Do you want to review this PR? Currently checking the PRs and issues. |
NikCharlebois
requested changes
Oct 30, 2024
| ( | ||
| [Parameter()] | ||
| [System.String] | ||
| $Guid, |
There was a problem hiding this comment.
Since this is the key, it is required for the property to be marked as mandatory. Otherwise Start-DSCConfiguration will fail.
There was a problem hiding this comment.
@sasistla, could you please fix this last comment today? Then we can include it in the next release.
|
Putting this PR On-Hold as we are awaiting additional details from the owning PG to better understand how the underlying cmdlets work and what their impact on the environment is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new resource device tenant policy in S&C