ExoMailboxStatistics initial release #3866
Conversation
| @@ -0,0 +1,74 @@ | |||
| [ClassVersion("1.0.0.0"), FriendlyName("EXOMailboxStatistics")] | |||
| class MSFT_EXOMailboxStatistics : OMI_BaseResource | |||
| { | |||
There was a problem hiding this comment.
The resource should have at least one Key parameter. This is currently causing failing QA tests.
| [OutputType([System.Collections.Hashtable])] | ||
| param | ||
| ( | ||
| ######################## |
There was a problem hiding this comment.
If this is the minimum property set, shouldn't all properties be mandatory??
| class MSFT_EXOMailboxStatistics : OMI_BaseResource | ||
| { | ||
| [Write, Description("")] String DeletedItemCount; | ||
| [Write, Description("")] String DisplayName; |
There was a problem hiding this comment.
The DisplayName is Mandatory in the code. That means that this property should either be Required or Key in the schema.
| [ClassVersion("1.0.0.0"), FriendlyName("EXOMailboxStatistics")] | ||
| class MSFT_EXOMailboxStatistics : OMI_BaseResource | ||
| { | ||
| [Write, Description("")] String DeletedItemCount; |
There was a problem hiding this comment.
Please add a description to each property. We are using that to generate documentation.
| [Write, Description("")] String SystemMessageSizeShutoffQuota; | ||
| [Write, Description("")] String SystemMessageSizeWarningQuota; | ||
|
|
||
| [Write, Description("Present ensures the group exists, absent ensures it is removed"), ValueMap{"Present","Absent"}, Values{"Present","Absent"}] string Ensure; |
There was a problem hiding this comment.
Looks like this description is a copy/paste. Please correct
| $ManagedIdentity | ||
| ) | ||
|
|
||
| throw 'Updating Mailbox Statistics is not supported.' |
There was a problem hiding this comment.
This looks very strange. You are now trying to use DSC to retrieve information from M365. That is not what DSC is meant for.
@NikCharlebois, @andikrueger, what is your opinion on this implementation?
There was a problem hiding this comment.
@ykuijs, I have inherited this PR. The customer who initiated the PR uses the mailbox statistic data to control the flow of a restore. Right, a resource that only reads data is not the primary goal of but there are examples that follow a similar pattern like PendingReboot.
If you are supporting the idea in general I will make the requested code changes.
There was a problem hiding this comment.
PendingReboot actually changes something, it updates the $global:DSCMachineStatus variable.
I am leaning towards a feeling that M365DSC isn't the correct place for just retrieving information, especially for information that can be a very large data set (for environments that have large amounts of mailboxes, which can be the case quickly).
@NikCharlebois, what is your opinion on this resource?
(Responses might be a little delayed, since Nik is off at the moment)
There was a problem hiding this comment.
I would not implement this kind of change even though it is tempting to have the additional information in the exported data. #4375 describes a similar ask for a read-only property.
|
Please close the PR or update with the latest changes. |
Pull Request (PR) description