Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparation for IContainerRuntimeOptions.enableGroupedBatching removal #23325

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Preparation for IContainerRuntimeOptions.enableGroupedBatching removal #23325

merged 4 commits into from
Dec 16, 2024

Conversation

MarioJGMsoft
Copy link
Contributor

@MarioJGMsoft MarioJGMsoft commented Dec 13, 2024 •
edited
Loading

Description

This PR is a preparation for the breaking change that will happen when we remove IContainerRuntimeOptions.enableGroupedBatching

Breaking Changes

Link to the breaking issue: #23270

Reviewer Guidance

  • Let me know if I missed something or if there's a better solution for what I want to accomplish

Owning Task: AB#26793

@github-actions github-actions bot added area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc public api change Changes to a public API base: main PRs targeted against main branch labels Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170006 links
    1595 destination URLs
    1825 URLs ignored
       0 warnings
       0 errors

@MarioJGMsoft MarioJGMsoft marked this pull request as ready for review December 13, 2024 23:19
@MarioJGMsoft MarioJGMsoft requested a review from a team as a code owner December 13, 2024 23:19
@github-actions github-actions bot removed the public api change Changes to a public API label Dec 13, 2024
@MarioJGMsoft MarioJGMsoft linked an issue Dec 16, 2024 that may be closed by this pull request
Removal of IContainerRuntimeOptions.enableGroupedBatching in v2.20 #23270
Open
@MarioJGMsoft MarioJGMsoft requested review from a team, pragya91, markfields, jatgarg, tyler-cai-microsoft, kian-thompson and rajatch-ff and removed request for a team December 16, 2024 20:36
markfields
markfields approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@markfields markfields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MarioJGMsoft MarioJGMsoft merged commit 489c5cc into microsoft:main Dec 16, 2024
30 checks passed
@MarioJGMsoft MarioJGMsoft deleted the removeDeprecatedEnableGroupedBatching branch December 16, 2024 22:18
@MarioJGMsoft MarioJGMsoft removed a link to an issue Dec 16, 2024
Removal of IContainerRuntimeOptions.enableGroupedBatching in v2.20 #23270
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noencke noencke noencke approved these changes

@markfields markfields markfields approved these changes

@pragya91 pragya91 Awaiting requested review from pragya91 pragya91 was automatically assigned from microsoft/team-rajat

@jatgarg jatgarg Awaiting requested review from jatgarg jatgarg was automatically assigned from microsoft/team-rajat

@tyler-cai-microsoft tyler-cai-microsoft Awaiting requested review from tyler-cai-microsoft tyler-cai-microsoft was automatically assigned from microsoft/team-rajat

@kian-thompson kian-thompson Awaiting requested review from kian-thompson kian-thompson was automatically assigned from microsoft/team-rajat

@rajatch-ff rajatch-ff Awaiting requested review from rajatch-ff rajatch-ff was automatically assigned from microsoft/team-rajat

Assignees
No one assigned
Labels
area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarioJGMsoft @markfields @noencke