Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ignore_index to sequence parallel cross entropy #6882

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Adds ignore_index to sequence parallel cross entropy #6882

wants to merge 4 commits into from

Conversation

ronald-d-rogers
Copy link

@ronald-d-rogers ronald-d-rogers commented Dec 17, 2024 •
edited
Loading

Simple change to add ignore_index to 100% integration w/ Hugging Face:
huggingface/transformers#35301

I also considered adding reduction here, and just returning loss.mean()/sum() accordingly. I can add that as well if you all thinks that makes sense.

@ronald-d-rogers
Copy link
Author

@microsoft-github-policy-service agree [company="Bloomberg Industry Group"]

@ronald-d-rogers
Copy link
Author

@microsoft-github-policy-service agree company="Bloomberg Industry Group"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loadams loadams loadams approved these changes

@tjruwase tjruwase Awaiting requested review from tjruwase

@tohtana tohtana Awaiting requested review from tohtana tohtana is a code owner

@samadejacobs samadejacobs Awaiting requested review from samadejacobs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronald-d-rogers @loadams @tjruwase