Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow launcher to include --include=node3, not just --include=node3:1,2,3,4,5,6,7,8 #6698

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

stephen-nju
Copy link

@stephen-nju stephen-nju commented Nov 1, 2024

Fixes: #6671

@stephen-nju stephen-nju requested a review from loadams as a code owner November 1, 2024 07:17
@stephen-nju stephen-nju requested a review from loadams November 9, 2024 06:27
@loadams
Copy link
Contributor

loadams commented Nov 12, 2024

Thanks @stephen-nju - sorry for the delay in reviewing, I'll get to this shortly

@stephen-nju
Copy link
Author

@loadams can I close this pull request?

@loadams
Copy link
Contributor

loadams commented Nov 14, 2024

@loadams can I close this pull request?

@stephen-nju please leave it open, we can review and merge and that will close it

@loadams loadams changed the title fix issue #6671 Fix issue #6671 Nov 15, 2024
@loadams loadams changed the title Fix issue #6671 Allow launcher to include --include=node3, not just --include=node3:1,2,3,4,5,6,7,8 Nov 15, 2024
@VeryLazyBoy
Copy link
Contributor

Hi @loadams, has there been any progress on this PR? I believe the regression failure is due to a recent update in #6530, where the empty list from --include takes precedence over the host file configuration.

@loadams
Copy link
Contributor

loadams commented Dec 5, 2024

Hi @loadams, has there been any progress on this PR? I believe the regression failure is due to a recent update in #6530, where the empty list from --include takes precedence over the host file configuration.

Hi @VeryLazyBoy - we have been working on a few other releases, thanks for the reminder on this PR, I will work on getting this PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when parsing GPUs on a node when only specifying node name --include=node3 vs --include=node3:1,2,4
3 participants