-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic typescript typings #53
base: master
Are you sure you want to change the base?
Conversation
any thoughts? |
Would love to see this get merged. |
Yeah, lets see, been a while... |
@jonschlinkert would this be better to live here or on DefinitelyTyped? |
I just added picomatch types to DefinitelyTyped. This can be closed. |
from my point of view, it would be nicer to always have the types as part of the package, and always have it matching without additional manual effort but thanks @Patcher56, I'll probably go ahead and use those types to convert my project to using picomatch |
Yeah, I am the same opinion. But as we didn't get an answer this is the only option to add types to picomatch. The best solution in my opinion would be to convert picomatch to typescript. Then the types would be no problem at all. |
This PR adds basic typescript typings based on the existing jsdoc comments.
The types are not perfect as they are auto generated, but on the other hand it does not need to be maintained manually, and something is better than nothing. The automatic generation of types from Javascript was introduced in https://devblogs.microsoft.com/typescript/announcing-typescript-3-7/
#18