Added volumes and volume mounts variables to be able to use wordforms… #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….txt and stopwords.txt
fgroenendijk
force-pushed
the
feat/allow-custom-stopwords-and-wordforms
branch
from
b9a1ba7 to
f4cfd54
Compare
djklim87
requested changes
May 29, 2024
| @@ -120,6 +127,11 @@ spec: | |||
| - name: config-volume | |||
| configMap: | |||
| name: {{ include "manticoresearch.fullname" . }}-balancer-config | |||
| {{- range .Values.balancer.volumes }} | |||
There was a problem hiding this comment.
Probably you forgot to add this variable to values.yml
| @@ -120,6 +127,11 @@ spec: | |||
| - name: config-volume | |||
| configMap: | |||
| name: {{ include "manticoresearch.fullname" . }}-balancer-config | |||
| {{- range .Values.balancer.volumes }} | |||
| - name: {{ .name }} | |||
| configMap: | |||
There was a problem hiding this comment.
Using the config map here is not a good idea. The ConfigMap size limit is 1 MB.
Wordforms can be pretty big, it's noticed in our documentation
There was a problem hiding this comment.
Ok, looked into this. I'm at a loss as how to solve this. Do you have a suggestion for me?
There was a problem hiding this comment.
Mount volume as file and pass into creation table command link to mounted file as it described here
| @@ -132,6 +139,11 @@ spec: | |||
| - name: config-volume | |||
| configMap: | |||
| name: {{ include "manticoresearch.fullname" . }}-worker-config | |||
| {{- range .Values.worker.volumes }} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
….txt and stopwords.txt.
For some context, I needed to change the stopwords to fit our usecase. In this way it's possible to provide a different wordforms.txt and stopwords.txt file.
Let me know if you need anything else from me.