[NNNN] Target Extension Types for Inline SPIR-V and Decorated Types #105
Conversation
This adds target extension types to represent `SpirvType` from HLSL 0011, Inline SPIR-V.
| To represent `vk::SpirvType` and `vk::SpirvOpaqueType` in LLVM IR, we will add | ||
| three new target extension types: | ||
|
|
||
| * `spirv.inline.Type` |
There was a problem hiding this comment.
Have you looked into how the size and alignment information can be encoded? How do you get TargetExtType::getLayoutType() to return the right value?
https://llvm.org/doxygen/classllvm_1_1TargetExtType.html#ae473a097292848f10f82f0961245e012
Are we okay with it returning void? It seems like the information comes from getTargetTypeInfo in Type.cpp. Will you be able to set this properly? Do we need optional integer arguments that have the size and alignment?
If we do have the size and alignment, what is the layout type?
Also, which properties should be set?
| %ArrayTex2D = type target("spirv.inline.Type", %type_2d_image, %integral_constant_4, 28) | ||
| ``` | ||
|
|
||
| ### Type decorations |
There was a problem hiding this comment.
You should mention that this is related to the decoration attribute in inline spir-v, which can only be applied to types and member variables. Talk about how that attribute will be translated into something of this type. I believe this has alternative solutions that we discussed. The might be worth mentioning in the alternative solutions seciton.
Lastly, you need to consider all versions of the decoration, decorateId and decorateString? Do we want multiple versions? Use the IngralConstant, Literal, and some other String class?
Sorry, I should have mentioned these variants when I asked you to include the decorations in this design.
There was a problem hiding this comment.
Also I had not noticed int_spv_assign_decoration in https://github.com/llvm/llvm-project/blob/main/llvm/docs/SPIRVUsage.rst#target-intrinsics. We should explain why we are not using it, if we decide not to use it. If it does work for us, then that could be a better solution.
| of the SPIR-V Specification. This will create a unique SPIR-V type with the | ||
| specified `OpDecoration`. |
There was a problem hiding this comment.
I would call out more explicitly this does not add a decoration to the id for type. In must create a new type with a new id.
| * `spirv.inline.Type` | ||
| * `spirv.inline.IntegralConstant` | ||
| * `spirv.inline.Literal` |
There was a problem hiding this comment.
Is there a reason we need inline in the name? I think it could be removed in all of the types.
| `spirv.DecoratedType` target extension type. | ||
|
|
||
| ``` | ||
| target("spirv.DecoratedType", type, decoration) |
There was a problem hiding this comment.
Some decorations have operands. This might need to be more general.
This adds target extension types to represent
SpirvTypefrom HLSL 0011, Inline SPIR-V.