You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#7756 adds the SymbiYosys test runner and requires the sby feature, but did not add the corresponding available feature in lit.cfg.py, so this test never seems to run, and #7763 introduces a syntax error, a backslash in the f-string expression part, in the Python script.
Unlike #7884, there is no need to modify PATH variable for the script since sby should be in the PATH if we can check it in CMake.
If you would like to land this yourself once CI passes, feel free to obtain commit access to LLVM. Otherwise let me know and I can merge things for you 😃
@unlsycn I have added SymbiYosys and a more up-to-date build of Yosys to the integration test CI image (v18.0) in #7895. I'll land that in a few minutes if CI passes. Once that's in main, you could try to rebase this PR onto main and see if the integration test CI picks up the SymbiYosys installation and the test you fixed here now runs 🙂
It looks like something might be broken in the integration image's sby setup 😞, sorry about that. This is going to be a bit annoying to debug. One approach could be to tweak the circt-test-runner-sby.py file to not just say "see xyz.log", but to make it read and print that xyz.log. That would allow us to see the sby output log in the GitHub action.
It looks like something might be broken in the integration image's sby setup 😞, sorry about that. This is going to be a bit annoying to debug. One approach could be to tweak the circt-test-runner-sby.py file to not just say "see xyz.log", but to make it read and print that xyz.log. That would allow us to see the sby output log in the GitHub action.
It looks like something might be broken in the integration image's sby setup 😞, sorry about that. This is going to be a bit annoying to debug. One approach could be to tweak the circt-test-runner-sby.py file to not just say "see xyz.log", but to make it read and print that xyz.log. That would allow us to see the sby output log in the GitHub action.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unlsycn
force-pushed
the
test-sby-fix
branch
from
#7756 adds the SymbiYosys test runner and requires the
sbyfeature, but did not add the corresponding available feature inlit.cfg.py, so this test never seems to run, and #7763 introduces a syntax error, a backslash in the f-string expression part, in the Python script.Unlike #7884, there is no need to modify PATH variable for the script since
sbyshould be in the PATH if we can check it in CMake.