Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymer 1.0+ #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

therewasaguy
Copy link
Member

I don't think we're ready to merge this in yet, but here's what it took to get this element ready for polymer 1.0+

Documentation

  • replace index.html with new index.html and use iron-component-page. This automatically parses any properties and documentation. Privates should be prefixed with an underscore.
  • add "@ demo" to automatically include a link to the demo

Demo

  • demo.html --> demo/index.html
  • template is="auto-binding" no longer works. Instead, fire a 'lens-output-changed' event on _calculateOutput, and use document.addEventListener('lens-output-changed', callback) to get the output when it changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant