Fix Envoy proxy failing in tcp-metrics #49
Conversation
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack. |
Description: This fixes a previous open issue layer5io#39 Updated envoy.yaml - Envoy now calls for typed_config in `v3` - Rearranged placement of the filters, but it probably can be reworked to make it cleaner - Clusters is now set up with an endpoint, instead of `hosts` - Probably need to fix spacing Signed-off-by: Antonette Caldwell <[email protected]>
acald-creator
force-pushed
the
envoy-proxy-fix
branch
from
1139048 to
6f39f3e
Compare
leecalcote
requested review from
DelusionalOptimist,
kanishkarj,
Revolyssup and
antweiss
and removed request for
DelusionalOptimist
|
@felixfaisal you're welcome to offer review... |
|
Thanks @leecalcote |
|
@felixfaisal Thanks! This PR will have more updates very soon. I just have the JWT to finish up and then this PR will be updated. |
|
@felixfaisal Is this PR sufficient at this time? Sorry, time got away from me, and I'm circling back now to finish the rest of the PR. However, I want to finish the JWT on a separate branch which I have it at here https://github.com/acald-creator/wasm-filters/tree/test-filters. I wanted to research the information about JWT manipulation since the readme was scarce. But for now, this PR should be go to go unless something is wrong. If there is something wrong, I can fix it which I probably already did from the other branch. |
There was a problem hiding this comment.
I see nothing wrong with @acald-creator and her work here. The issue appears to be corrected and if there are no further problems, her fix seems to have done the trick. @leecalcote
Description
This PR Fixes #39
Updated
envoy.yamltyped_configinv3hostsproxy-wasmfromv0.1.0tov0.2.0envoy.yamlwill need to be updated, currently working on the rest and will add to this PR.Signed-off-by: Antonette Caldwell [email protected]
Notes for Reviewers
Signed commits