Incorrect download of design from client #844
Open
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Md Kaif Ansari <[email protected]>
Signed-off-by: Md Kaif Ansari <[email protected]>
pranjalg1331
reviewed
Dec 9, 2024
There was a problem hiding this comment.
@mdkaifansari04 I assume that you have tested your changes with my pr with the updated handler?
https://github.com/layer5io/meshery-cloud/pull/3060
| @@ -47,6 +47,20 @@ export const downloadFilter = (id: string, name: string): void => { | |||
| linkElement.remove(); | |||
| }; | |||
|
|
|||
| export const downloadPattern = (id: string, name: string, type: string): void => { | |||
| const pattern = type == 'design' ? 'patterns' : 'filters'; | |||
| const dataUri = `${process.env.API_ENDPOINT_PREFIX}/api/content/${pattern}/download/${id}`; | |||
There was a problem hiding this comment.
@mdkaifansari04 how you are accessing env variable here directly in sistent?
| const dataUri = `${process.env.API_ENDPOINT_PREFIX}/api/content/${pattern}/download/${id}`; | ||
|
|
||
| // Add the .wasm extension to the filename | ||
| const fileNameWithExtension = name + '.wasm'; |
There was a problem hiding this comment.
exactly? Document well things while adding new things what and why's?
sudhanshutech
requested changes
Dec 10, 2024
| @@ -47,6 +47,20 @@ export const downloadFilter = (id: string, name: string): void => { | |||
| linkElement.remove(); | |||
| }; | |||
|
|
|||
| export const downloadPattern = (id: string, name: string, type: string): void => { | |||
| const pattern = type == 'design' ? 'patterns' : 'filters'; | |||
| const dataUri = `${process.env.API_ENDPOINT_PREFIX}/api/content/${pattern}/download/${id}`; | |||
There was a problem hiding this comment.
@mdkaifansari04 how you are accessing env variable here directly in sistent?
| const dataUri = `${process.env.API_ENDPOINT_PREFIX}/api/content/${pattern}/download/${id}`; | ||
|
|
||
| // Add the .wasm extension to the filename | ||
| const fileNameWithExtension = name + '.wasm'; |
There was a problem hiding this comment.
exactly? Document well things while adding new things what and why's?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixed the download of design, before it was downloded from client-side but now the design is been downloaded form server directly.
This PR fixes #
Signed commits