Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image issue #6120

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix image issue #6120

wants to merge 10 commits into from

Conversation

Ajay-singh1
Copy link
Contributor

@Ajay-singh1 Ajay-singh1 commented Dec 10, 2024

Description

I have fixed the image issue in which their was a png file within the svg file also I have updated the wrong className so that the necessary property of the CSS is applied.I have also added another SVG TemplateWhite for light mode which will make the user interface consistent to different themes.

This PR fixes #5467

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@Ajay-singh1 Ajay-singh1 changed the title Removed unnecessary boolean condition Fix image issue Dec 10, 2024
@l5io
Copy link
Contributor

l5io commented Dec 10, 2024

🚀 Preview for commit 997abdb at: https://6758565d60435f6227f0395a--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 10, 2024

🚀 Preview for commit cb06ee8 at: https://675862cf3aba0800813f5053--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 12, 2024

🚀 Preview for commit bf31c1c at: https://675a4807577d84cf83b2cb1c--layer5.netlify.app

@Ajay-singh1 Ajay-singh1 marked this pull request as draft December 12, 2024 02:27
@l5io
Copy link
Contributor

l5io commented Dec 12, 2024

🚀 Preview for commit a223d57 at: https://675a4cc74b7dd2c9047354f6--layer5.netlify.app

Signed-off-by: Ajay Singh <[email protected]>
Signed-off-by: Ajay Singh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 12, 2024

🚀 Preview for commit 1d54ea2 at: https://675a55026eb9b79af7a67bbf--layer5.netlify.app

Signed-off-by: Ajay Singh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 12, 2024

🚀 Preview for commit 94c84b3 at: https://675a5c2e4b7dd2dcdf735178--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 12, 2024

🚀 Preview for commit dbe16d7 at: https://675a691eb7f803f2d960ab50--layer5.netlify.app

@Ajay-singh1 Ajay-singh1 marked this pull request as ready for review December 12, 2024 04:48
@Ajay-singh1
Copy link
Contributor Author

@leecalcote Indeed their was a PNG File within this SVG I have fixed it.

@Ajay-singh1
Copy link
Contributor Author

🚀 Preview for commit dbe16d7 at: https://675a691eb7f803f2d960ab50--layer5.netlify.app

Final Result.

@l5io
Copy link
Contributor

l5io commented Dec 13, 2024

🚀 Preview for commit ce4ee09 at: https://675ba2e46168b35f98b78323--layer5.netlify.app

@mdkaifansari04
Copy link
Contributor

Looks good @Ajay-singh1, dark and light svg is also working 👍

@vishalvivekm
Copy link
Member

@Ajay-singh1
Thank you for your contribution!
Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

PNG masquerading as an SVG
4 participants