Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card sistent component #6085

Closed

Conversation

Anand-Theertha
Copy link
Contributor

@Anand-Theertha Anand-Theertha commented Nov 18, 2024

Description

This PR fixes #5908. This PR adds a Card component to the Sistent components. Following are a few screenshots of how the implementation looks:

image

image

image

Notes for Reviewers

  1. Check description of each type of Card to ensure sufficient information is provided to the user.
  2. Ensure all important types of cards are present.

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added area/projects An issue relating to Layer5 initiatives (projects) project/sistent labels Nov 18, 2024
@l5io
Copy link
Contributor

l5io commented Nov 19, 2024

🚀 Preview for commit 3c75342 at: https://673ca2742fbcdf34f871fb47--layer5.netlify.app

Signed-off-by: Anand-Theertha <[email protected]>
@l5io
Copy link
Contributor

l5io commented Nov 20, 2024

🚀 Preview for commit 8fafebc at: https://673debc2bd0ffbc2451e7ea3--layer5.netlify.app

@sudhanshutech
Copy link
Member

@Anand-Theertha change the structure of page as per new changes made around adding sistent components.

@Anand-Theertha
Copy link
Contributor Author

Alright, will do. Where can I find these new changes?

Copy link
Contributor

@Vidit-Kushwaha Vidit-Kushwaha Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could you remove SistentthemeProvider from code example
  • Could you remove the excess indentation from code example so that it looks more uniform?

@sudhanshutech
Copy link
Member

Alright, will do. Where can I find these new changes?

you don't need create directories under pages that will automatically will taken taken care.

@sudhanshutech
Copy link
Member

@Anand-Theertha wrap this quickly

@vishalvivekm
Copy link
Member

@Anand-Theertha
Thank you for your contribution!
Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

@Anand-Theertha
Copy link
Contributor Author

Will do @sudhanshutech

@sudhanshutech
Copy link
Member

@Anand-Theertha still pending?

@sudhanshutech
Copy link
Member

@Anand-Theertha ?

@sudhanshutech
Copy link
Member

@Anand-Theertha i am closing this due to no activity for others to work, please reopen if you are active again

@Anand-Theertha
Copy link
Contributor Author

Anand-Theertha commented Dec 9, 2024

Reopened a PR fixing the same issue with all of the changes requested: #6117. Please look into it and let me know if any further changes are needed. Thank you.

@sudhanshutech

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/projects An issue relating to Layer5 initiatives (projects) project/sistent
Development

Successfully merging this pull request may close these issues.

[Sistent] Add Card component to the sistent components page
5 participants