-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card sistent component #6085
Card sistent component #6085
Conversation
Signed-off-by: Anand-Theertha <[email protected]>
Signed-off-by: Anand-Theertha <[email protected]>
Signed-off-by: Anand-Theertha <[email protected]>
🚀 Preview for commit 3c75342 at: https://673ca2742fbcdf34f871fb47--layer5.netlify.app |
Signed-off-by: Anand-Theertha <[email protected]>
🚀 Preview for commit 8fafebc at: https://673debc2bd0ffbc2451e7ea3--layer5.netlify.app |
@Anand-Theertha change the structure of page as per new changes made around adding sistent components. |
Alright, will do. Where can I find these new changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Could you remove SistentthemeProvider from code example
- Could you remove the excess indentation from code example so that it looks more uniform?
you don't need create directories under pages that will automatically will taken taken care. |
@Anand-Theertha wrap this quickly |
@Anand-Theertha adding it as an agenda item to the meeting minutes. |
Will do @sudhanshutech |
@Anand-Theertha still pending? |
@Anand-Theertha i am closing this due to no activity for others to work, please reopen if you are active again |
Reopened a PR fixing the same issue with all of the changes requested: #6117. Please look into it and let me know if any further changes are needed. Thank you. |
Description
This PR fixes #5908. This PR adds a Card component to the Sistent components. Following are a few screenshots of how the implementation looks:
Notes for Reviewers
Signed commits