Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main.go #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShivangShandilya
Copy link

Description

This PR fixes #288

Notes for Reviewers

log.Fatal() has been replaced with log.Error()

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Shivang Shandilya <[email protected]>
@welcome
Copy link

welcome bot commented Apr 11, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@leecalcote leecalcote requested a review from gyohuangxin April 11, 2023 16:27
@leecalcote leecalcote added the language/go Golang related label Apr 11, 2023
Copy link
Member

@gyohuangxin gyohuangxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShivangShandilya Thanks for your PR, I left a comment.

cmd/main.go Show resolved Hide resolved
@gyohuangxin gyohuangxin requested a review from leecalcote April 15, 2023 13:23
@leecalcote leecalcote requested review from Revolyssup and removed request for leecalcote May 2, 2023 15:41
@Chadha93
Copy link
Member

Thanks, @ShivangShandilya, could you help with the Go lint issue too here?

@ShivangShandilya
Copy link
Author

Thanks, @ShivangShandilya, could you help with the Go lint issue too here?

Can you elaborate on this??

@Sweetdevil144
Copy link

I personally would favor usage of log.Fatal instead of consequent log.Error and return statements. It is because return statementstend to return while log.Fatal tends to stop the program. Imagine threading situations, where Fatal would be preferred over return's. I'd say this PR will rather degrade the system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/go Golang related
Development

Successfully merging this pull request may close these issues.

Changes in main.go
5 participants