[11.x] Use Str::wrap() instead of nesting Str::start() inside Str::finish()

[shaedrich]

Btw, is there a reason, why the null coalescing assignment operator is used instead of just the null coalescing operator?

framework/src/Illuminate/Support/Str.php

Lines 441 to 452 in 5d81b45

	/**
	* Wrap the string with the given strings.
	*
	* @param string $value
	* @param string $before
	* @param string|null $after
	* @return string
	*/
	public static function wrap($value, $before, $after = null)
	{
	return $before.$value.($after ??= $before);
	}

[sydgren]

Btw, is there a reason, why the null coalescing assignment operator is used instead of just the null coalescing operator?

framework/src/Illuminate/Support/Str.php

Lines 441 to 452 in 5d81b45

	/**
	* Wrap the string with the given strings.
	*
	* @param string $value
	* @param string $before
	* @param string|null $after
	* @return string
	*/
	public static function wrap($value, $before, $after = null)
	{
	return $before.$value.($after ??= $before);
	}

It does indeed seem unnecessary to reassign the $after variable.

I guess it's some leftovers from a previous change. Perhaps $after ??= $before has been on its own line above the return statement?

[shaedrich]

Would make sense, but—I checked it real quick—nope, it's always been this way (since 8ea50bc) 🤔

@stevebauman Is there a reason behind that, that we are missing or can the equal sign be removed?