Fix: Prevent exception when parsing request port in ServeCommand #53957
+31
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where
php artisan serve
throws an exception on Windows when a log line does not contain a valid request port.Problem
"process forking is not supported" when running the "artisan serve", and the
flushOutputBuffer
method tries to parse invalid lines. This raises the exceptionSolution
Accepted
,Closing
) before callinggetRequestPortFromLine
.Changes Made
flushOutputBuffer
method inServeCommand.php
:contains()
checks for specific keywords.How to Test
php artisan serve
.