-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.x] Added Automatic Relation Loading (Eager Loading) Feature #53655
base: master
Are you sure you want to change the base?
Conversation
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a very desired and powerful feature. It's going to save a lot of effort. I hope it will be approved soon. Thank you so much!
I'm not sure I understand this -- isn't this typical Eloquent lazy-loading behaviour? Won't the relations in your example be loaded via lazy-loading? Ex, this should work already: $orders = Order::all();
foreach ($orders as $order) {
echo $order->client->owner->company->name;
} Or are you referring to preventing the possibility from N+1'ing due to the above lazy loading? Please correct me if I'm misunderstanding 🙏 |
You’re absolutely right, and typically, methods like In such cases, it can become difficult to track and manually specify which relations should be eager-loaded, especially if those relations are deeply nested or dynamically used. The In your example: $orders = Order::all();
foreach ($orders as $order) {
echo $order->client->owner->company->name;
} If there are 10 orders, here’s what happens: With It's very simple example, we can just use with the same result $orders->load('client.owner.company'); But if we change our code in the future, the relations will be loaded unnecessarily until we explicitly remove them from the load. foreach ($orders as $order) {
echo $order->client->name;
} Let me know if this makes sense or if you’d like further clarification! 🙏 |
I am not sure if I fully understand this, so sorry in advance if I don't make sense. But if this works as you say, wouldn't it make sense to replace the current lazy loading behaviour instead of making your feature opt-in? |
Thanks for the question! The feature is opt-in to avoid forcing developers who prefer manual control over relation loading and to preserve the existing lazy-loading behavior. This also helps prevent potential issues in existing projects relying on the default behavior. However, if desired, you can enable it globally for the entire project using |
This is a great idea especially for junior devs to avoid N+1 issues |
Isn't that essentially what the Eager Loading by Default (from the Laravel docs)
|
No. As far as I understand this PR loads relationship for Collection only when it's accessed from one of Collection's Model. So you don't need As a result you don't need to specify relationships names anywhere at all except in the code itself to use them. With Model |
I’ll add a few more points: The $posts = Post::all()->loadMorph('commentable', [
Article::class => ['author'],
Video::class => ['channel'],
]); However, even With $posts = Post::all()->withRelationAutoload();
foreach ($posts as $post) {
echo $post->commentable->author->name; // Automatically loads related morphs and nested relations
} |
|
I completely agree with @moisish; it’s a great idea to avoid N+1 issues. I’ve already tried this functionality, and it works really well. @litvinchuk, thank you for your explanations. I think this is truly a great solution and worth attention. Great work! |
I've seen this idea previously done by @liam-wiltshire with https://github.com/liam-wiltshire/laravel-jit-loader which @staudenmeir was a contributor and he is an Eloquent wizard so I feel like this could be a good idea. |
Thanks for mentioning that! I hadn’t come across this package before, but after taking a look, it seems to work a bit differently from this implementation. While it also avoids the need to explicitly define relationship names (which is great), it seems to run into N+1 problems after the second level of nested relationships. And it doesn’t support polymorphic relationships. |
@litvinchuk Thank you so much for this PR! This is undoubtedly one of the most significant improvements, and I can’t wait to start using it. I’ve always been looking for this kind of enhancement in Eloquent, and it’s amazing to see it implemented. Features like this make working with the framework even more enjoyable and efficient. Great job! 🎉 |
@litvinchuk nice idea. For eloquent collection this makes sense, but for the model alone it doesn't. Can you confirm that this will improve just the eloquent collections? Also, since laravel 10 https://laravel.com/docs/10.x/releases#main-content |
Could you clarify why you believe automatic relation loading is not suitable for models? I think it’s particularly useful for deep relations, where it simplifies the process of loading nested dependencies automatically.
I aimed to follow the existing coding style in the relevant classes. If you notice specific issues with type hints or return types, could you please leave a comment under the corresponding line of code? |
I just asked because if you have the model hydrated in memory, and it is only 1 model, then lazy loading a relation on it will generate just 1 query. Why eager load for just 1 model? (I am not stating, just asking to understand). If you were referring to 1 model in memory that has loaded in it a relation of to many type so, the relation is a collection not a model, then the eloquent collection auto eager loading applies also to that by default.
I quit doing that because Taylor would revert the changes done by the author before merging so, I concluded that it is not allowed. (later I understood why - it breaks the application because the dockblocks are not accurate - I saw int in dockblock and Builder as response). I just asked you this to have another opinion on it. |
You’re right — when accessing something like For example: foreach ($user->articles as $article) {
echo $article->category->name;
} In this case, we encounter the N+1 problem, where a query is executed for each article’s category. |
For your information, Laravel has a corner case bug/issue on eager loading that will affect (or is affecting) also this feature. |
Lowkey funny that nobody actually wants to implement the fix that you shared for some reason. I'd love to take on it, but I feel like I'm way too dumb to go this deep into the Eloquent core. |
Description
In large projects it can become difficult to track and manually specify which relations should be eager-loaded, especially if those relations are deeply nested or dynamically used. Therefore, automatic relation loading can be useful.
Challenges include:
New
withRelationAutoload()
MethodA new method, withRelationAutoload(), has been added to models and Eloquent collections. When called, it automatically loads relations whenever they are accessed, without the need for explicit load() or with() calls.
Example:
Support for Morph Relations
The feature works seamlessly with polymorphic relations. It only loads the specific morph type that is accessed, ensuring efficient use of resources.
Doesn’t Break Manual Relation Loading
Users can still manually load relations using load() or with() before accessing the relation. If a relation is already loaded manually, it won’t be reloaded.
Global Automatic Loading
For cases where you want automatic loading enabled across all models, you can use the static method `
Model::globalAutoloadRelations();
This feature significantly simplifies working with relations and reduces the overhead of managing eager loading in Laravel projects, enabling developers to focus on application logic instead of data loading mechanics.
If you have suggestions for better method names, feel free to share them!