-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to use --static-ip when using a docker network with --network param #19512
base: master
Are you sure you want to change the base?
Fix to use --static-ip when using a docker network with --network param #19512
Conversation
#Issue 19284 - Use static ip with empty gateway info.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deenadayalansrinivasan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @deenadayalansrinivasan! |
Hi @deenadayalansrinivasan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can one of the admins verify this patch? |
kubernetes#19512 Removed the check for gateway and update static IP if specified with the --network param.
…cker network with --network param kubernetes#19512
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Issue #19284 - Use static ip with empty gateway info. Added a minor check to validate and use the static ip irrespective of the gateway when choosing a network.