-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devicemanager: add timeout for GetPreferredAllocation and Allocate RPC #129248
base: master
Are you sure you want to change the base?
Conversation
Hi @ytinirt. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ytinirt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/triage accepted |
Hi, thanks for the fix.
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
For devicemanager, add timeout for
GetPreferredAllocation
andAllocate
RPC, likePreStartContainer
already does.Make sure not stucking in those RPC, otherwise all new coming pods would be blocked on admitting.
Which issue(s) this PR fixes:
Fixes #129249
Special notes for your reviewer:
Timeout for
GetPreferredAllocation
andAllocate
RPC is consistent withPreStartContainer
, which takes 30 seconds.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: