Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize the hardcoded images used for warmpool pre-pulling #17144

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rifelpet
Copy link
Member

Fixes #16871

When AWS WarmPool is enabled, nodeup pre-pulls a hardcoded list of images based on the cluster's assets:

https://github.com/rifelpet/kops/blob/4a882890ff2addb1ae0f69f93280102969ab64d3/pkg/nodemodel/nodeupconfigbuilder.go#L490-L507

When a cluster has:

spec:
  assets:
    containerProxy: public.ecr.aws/1234

All of the assets are remapped to begin with the containerProxy value. This results in the WarmPool logic not matching against any of the cluster's assets, and nodeup doesn't treat the instance as being in the warm pool.

Now we run the hardcoded images through the same remapping logic to ensure its matched against any images used in the cluster's assets.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rifelpet. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 17, 2024
@rifelpet rifelpet marked this pull request as ready for review December 17, 2024 05:10
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024
@rifelpet
Copy link
Member Author

/hold
for manual testing with the e2e job's KOPS_BASE_URL.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
@rifelpet rifelpet force-pushed the warmpool-containerproxy branch from 4a88289 to 172ea41 Compare December 17, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kops cluster upgrade from 1.28.7 to 1.29.2 - warmpool instances join cluster and remain in notReady state
2 participants