Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced y with ✓ #1975

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replaced y with ✓ #1975

wants to merge 1 commit into from

Conversation

alf
Copy link

@alf alf commented Dec 18, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Replaces usage of y in the conversion table with ✓.

y is not a valid state according to the glossary.
It is hard to spot the difference between x and y, so fixing this will make it less likely that reads the wrong thing from the table.

If y does not mean ✓ then y should be added to the glossary.
Again, since these marks are hard to differentiate I hope this won't be necessary.

If `y` does not mean ✓ then `y` should be added to the glossary.
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Dec 18, 2024
Copy link

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 18, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @alf!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alf
Once this PR has been reviewed and has the lgtm label, please assign tessaio for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2024
@cdrage
Copy link
Member

cdrage commented Dec 18, 2024

Good catch @alf

Sign the k8s CLA and I can merge this in! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants