Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garbage collect NEGs in to-be-deleted state. #2750

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Garbage collect NEGs in to-be-deleted state. #2750

wants to merge 4 commits into from

Conversation

sawsa307
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 26, 2024
@sawsa307
Expand NEG GC with isPartialDeletion method.
697c1be 
* Existing NEG GC will always delete all GCE NEGs in NEG CR. With
  multi-subnet cluster enabled, we could do partial deletions, only on
  to-be-deleted NEGs.
@sawsa307
NEG GC should consider a SvcNeg as deletion candidate if it contains tbd
376c789 
NEGs.
@sawsa307
Refactor TestGarbageCollectionNegCrdEnabled
ed1037f
@sawsa307
Add tests for GC to-be-deleted NEGs.
7d86b8c
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sawsa307
Once this PR has been reviewed and has the lgtm label, please ask for approval from gauravkghildiyal. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 2, 2024
gauravkghildiyal
gauravkghildiyal reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@gauravkghildiyal gauravkghildiyal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An initial look here makes me wonder: "Are we forcing this new pattern of deleting NEGs into our existing flow?"

More precisely, the code right now handles the deletion of the SvcNEG and ALL of it's related NEGs. The part here where we also have to handle the deletion of the SvcNEG itself also adds other complications.

What we want to add now is the ability to just deleted targeted NEGs which have a specific state right? Have we thought about doing this in it's own piece of code? Would that be more easier or do we think that has it's own problems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravkghildiyal gauravkghildiyal gauravkghildiyal left review comments

@aojea aojea Awaiting requested review from aojea

@spencerhance spencerhance Awaiting requested review from spencerhance

Assignees

@swetharepakula swetharepakula

@gauravkghildiyal gauravkghildiyal

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sawsa307 @k8s-ci-robot @gauravkghildiyal @swetharepakula