Spelling #3400

jsoref · 2024-10-21T17:33:25Z

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/gateway-api/actions/runs/11444311412#summary-31838911907

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/gateway-api/actions/runs/11444311702#summary-31838912845

It also fixes the labels of a pair of images to match the word actually used

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Josh Soref <[email protected]>

k8s-ci-robot · 2024-10-21T17:33:34Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsoref
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2024-10-21T17:33:34Z

Welcome @jsoref!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-10-21T17:33:35Z

Hi @jsoref. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jsoref · 2024-10-21T17:36:01Z

RELEASE.md

@@ -70,7 +70,7 @@ The following steps must be done by one of the [Gateway API maintainers][gateway
 - Run the `make build-install-yaml` command which will generate install files in the `release/` directory.
  Attach these files to the GitHub release.
 - Update the `README.md` and `site-src/guides/index.md` files to point links and examples to the new release.
- Update the implementation table path (`nav.Implementations.Comparison`) in the nav of `mkdocs.yml` to point to the latest release file (for example Implementation Comparison points to `implmenetation-table-v1.2.0.md`). Add the now past version under `Past Version Comparisons`, and edit the text blurb in `mkdocs-generate-conformance.py` to also reflect the added past version.
+- Update the implementation table path (`nav.Implementations.Comparison`) in the nav of `mkdocs.yml` to point to the latest release file (for example Implementation Comparison points to `implementation-table-v1.2.0.md`). Add the now past version under `Past Version Comparisons`, and edit the text blurb in `mkdocs-generate-conformance.py` to also reflect the added past version.


I'm not sure about this one...

jsoref · 2024-10-21T17:36:25Z

apis/v1/util/validation/gatewayclass_test.go

@@ -20,7 +20,7 @@ import (
 	"testing"

 	gatewayv1 "sigs.k8s.io/gateway-api/apis/v1"
-	validationtutils "sigs.k8s.io/gateway-api/apis/v1beta1/util/validation"
+	validationutil "sigs.k8s.io/gateway-api/apis/v1beta1/util/validation"


this makes it consistent w/ another user...

jsoref · 2024-10-21T17:38:25Z

conformance/utils/suite/suite_test.go

@@ -181,7 +181,7 @@ func TestGetAPIVersionAndChannel(t *testing.T) {
 }

 const (
-	coreFeature     features.FeatureName = "coreFature"
+	coreFeature     features.FeatureName = "coreFeature"


this was odd... I hope it doesn't matter

jsoref · 2024-10-21T17:39:16Z

geps/gep-1364/index.md

@@ -418,7 +418,7 @@ For many implementations (certainly for Envoy-based ones), getting this informat
 correctly and avoiding races on applying it is surprisingly difficult. 

 For this reason, this GEP proposes that we exclude the `Ready` condition from Core
-conformance, and make it a feature that implementations may opt in to - making it
+conformance, and make it a feature that implementations may opt into - making it


People often complain about this change. I haven't merged opt in+to much in this PR. I'm happy to drop this or anything else.

jsoref · 2024-10-21T17:40:21Z

geps/gep-1762/metadata.yaml

@@ -5,7 +5,7 @@ name: In Cluster Gateway Deployments
 status: Standard
 authors:
  - howardjohn
-  - frakbu
+  - frankbu


notable correction

jsoref · 2024-10-21T17:43:02Z

geps/gep-724/images/724-alt1.png

#725 (review)

jsoref · 2024-10-21T17:43:21Z

geps/gep-724/index.md

@@ -618,7 +618,7 @@ bar namespace. Unfortunately that would be very difficult to recreate with
 ReferenceGrant.

 ReferenceGrant is fundamentally about trusting references from resource of kind
-Foo in to resources of kind Bar. Names and section names are intentionally
+Foo in resources of kind Bar. Names and section names are intentionally


this is notable

jsoref · 2024-10-21T17:43:48Z

geps/overview.md

@@ -59,7 +59,7 @@ of stability of the change described in the GEP:

  * **Provisional:** The goals described by this GEP have consensus but
    implementation details have not been agreed to yet.
-  * **Prototyping:** An extension of `Provisional` which can be opted in to in
+  * **Prototyping:** An optional extension of `Provisional` in


jsoref · 2024-10-21T17:44:15Z

hack/invalid-examples/standard/httproute/invalid-httpredirect-hostname.yaml

Afaict, this file isn't referenced anywhere...

-hack/invalid-examples/standard/httproute/invalid-httredirect-hostname.yaml +hack/invalid-examples/standard/httproute/invalid-httpredirect-hostname.yaml

jsoref added 30 commits October 18, 2024 03:08

spelling: adding

b1f5208

Signed-off-by: Josh Soref <[email protected]>

spelling: anymore

bd35f53

Signed-off-by: Josh Soref <[email protected]>

spelling: approach

33fafdc

Signed-off-by: Josh Soref <[email protected]>

spelling: attached

87c738a

Signed-off-by: Josh Soref <[email protected]>

spelling: because

6322a33

Signed-off-by: Josh Soref <[email protected]>

spelling: cannot

2585a66

Signed-off-by: Josh Soref <[email protected]>

spelling: case-insensitive

fcf6976

Signed-off-by: Josh Soref <[email protected]>

spelling: case-sensitive

3a8e19e

Signed-off-by: Josh Soref <[email protected]>

spelling: certificate

74899a9

Signed-off-by: Josh Soref <[email protected]>

spelling: certificates

282dc82

Signed-off-by: Josh Soref <[email protected]>

spelling: configuration

7235662

Signed-off-by: Josh Soref <[email protected]>

spelling: criteria

5abd182

Signed-off-by: Josh Soref <[email protected]>

spelling: deterministically

ef2cf47

Signed-off-by: Josh Soref <[email protected]>

spelling: discoverability

cc1a882

Signed-off-by: Josh Soref <[email protected]>

spelling: docs

3b722b7

Signed-off-by: Josh Soref <[email protected]>

spelling: encapsulated

0aa20bf

Signed-off-by: Josh Soref <[email protected]>

spelling: feature

f1a68bc

Signed-off-by: Josh Soref <[email protected]>

spelling: filesystem

fd0ab7e

Signed-off-by: Josh Soref <[email protected]>

spelling: format

f791dbd

Signed-off-by: Josh Soref <[email protected]>

spelling: frankbu

bdeb813

Signed-off-by: Josh Soref <[email protected]>

spelling: github

f88fa6d

Signed-off-by: Josh Soref <[email protected]>

spelling: grpc

d996a81

Signed-off-by: Josh Soref <[email protected]>

spelling: grpcroute

f0ffbb7

Signed-off-by: Josh Soref <[email protected]>

spelling: has

bd52f92

Signed-off-by: Josh Soref <[email protected]>

spelling: have

341db08

Signed-off-by: Josh Soref <[email protected]>

spelling: http-route

771f542

Signed-off-by: Josh Soref <[email protected]>

spelling: httpproxy

c70af0a

Signed-off-by: Josh Soref <[email protected]>

spelling: httpredirect

ae52a6b

Signed-off-by: Josh Soref <[email protected]>

spelling: https

6d6f2a4

Signed-off-by: Josh Soref <[email protected]>

spelling: implementation

c294db4

Signed-off-by: Josh Soref <[email protected]>

jsoref added 17 commits October 21, 2024 11:38

spelling: overridden

0a3553f

Signed-off-by: Josh Soref <[email protected]>

spelling: possible

a5b0dec

Signed-off-by: Josh Soref <[email protected]>

spelling: preexisting

f4ee83e

Signed-off-by: Josh Soref <[email protected]>

spelling: prominence

e6f1606

Signed-off-by: Josh Soref <[email protected]>

spelling: protocol

a36f67c

Signed-off-by: Josh Soref <[email protected]>

spelling: recommend

8580fef

Signed-off-by: Josh Soref <[email protected]>

spelling: reference-grant

06c41b8

Signed-off-by: Josh Soref <[email protected]>

spelling: referent

dc1346a

Signed-off-by: Josh Soref <[email protected]>

spelling: release

a0bf37d

Signed-off-by: Josh Soref <[email protected]>

spelling: route-override

312caba

Signed-off-by: Josh Soref <[email protected]>

spelling: stabilizing

bba9534

Signed-off-by: Josh Soref <[email protected]>

spelling: substituted

bafaf00

Signed-off-by: Josh Soref <[email protected]>

spelling: targeting

242f441

Signed-off-by: Josh Soref <[email protected]>

spelling: the

58e6025

Signed-off-by: Josh Soref <[email protected]>

spelling: validationutil

a16f558

Signed-off-by: Josh Soref <[email protected]>

spelling: which

0dcea2f

Signed-off-by: Josh Soref <[email protected]>

Reword simplify prototyping description

e9aac3d

Signed-off-by: Josh Soref <[email protected]>

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 21, 2024

k8s-ci-robot requested review from mikemorris and mlavacca October 21, 2024 17:33

jsoref commented Oct 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling #3400

Spelling #3400

jsoref commented Oct 21, 2024

k8s-ci-robot commented Oct 21, 2024

k8s-ci-robot commented Oct 21, 2024

k8s-ci-robot commented Oct 21, 2024

jsoref Oct 21, 2024

jsoref Oct 21, 2024

jsoref Oct 21, 2024

jsoref Oct 21, 2024

jsoref Oct 21, 2024

jsoref Oct 21, 2024

jsoref Oct 21, 2024

jsoref Oct 21, 2024

jsoref Oct 21, 2024

Spelling #3400

Are you sure you want to change the base?

Spelling #3400

Conversation

jsoref commented Oct 21, 2024

k8s-ci-robot commented Oct 21, 2024

k8s-ci-robot commented Oct 21, 2024

k8s-ci-robot commented Oct 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment