Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade eslint to v9.10.0 #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iambumblehead
Copy link

hello, this PR updates eslint to version 9.10.0 so npm install no longer shows red audit warning messages.

  • eslint 9 requires "eslint.config.js" added here,
  • xo is removed because it does not support eslint 9 Upgrade to ESLint 9 xojs/xo#757,
  • eslint-config-xo-lass exports an eslint 8 config, however its "rules" are usable with eslint 9 here,
  • unicorn is added as adependency, because some of its eslint rules are used by eslint-config-xo-lass,
  • many new and maybe pre-existing lint errors are raised --no effort is made to resolve the errors in this PR,
  • npm run lint fails because of the lint errors --no effort is made to resolve this,
  • because npm run lint fails, the husky commit hook fails

Hopefully this PR will be useful so that project owners may apply any remaining changes in ways they prefer.

Thank you :)

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@3imed-jaberi 3imed-jaberi force-pushed the master branch 3 times, most recently from 26805e9 to 057c50a Compare September 17, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants