Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional and local options #122

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Functional and local options #122

wants to merge 4 commits into from

Conversation

uhop
Copy link
Contributor

@uhop uhop commented Jul 7, 2020

As per #121 (comment)

Includes new tests, docs, passes ESLint, and the existing tests.

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           80        89    +9     
  Branches        29        31    +2     
=========================================
+ Hits            80        89    +9     
Impacted Files Coverage Δ
lib/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80054a5...4b0faed. Read the comment docs.

@jonathanong jonathanong self-assigned this Apr 20, 2021
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just should update as #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants