feat: add scaletargetref exists check in webhook and revise some variable name

[ctccxxd]

check scaletargetref exists in webhook and revise some variable name, originally,
1, There is not scaletargetref exists check code in webhook module.
2, Change the inappropriate variable name Gckr to Gvkr.
3, Upgrade crypto to v0.31.0 which is a imported package to fix vulnerabilities Trivy has detected.
4, If still want to remain the function to create scaleobj first without real scaletargetRef obj. Think whether this function will be a way can be configged, to confirm the real scaletargetRef obj already exists when we create/update scaleobj. In this way, it can avoid the user misconfigurations about scaletargetRef in yaml file.

Checklist

• I have verified that my change is according to the deprecations & breaking changes policy
• Tests have been added
• Changelog has been updated and is aligned with our changelog requirements
• A PR is opened to update the documentation on (repo) - add new function in doc keda-docs#1506
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #
#6354

[SpiritZhou]

Could you please open an issue for this improvement and relate this pr to the issue? This will make it clear and easy to tracing.

[ctccxxd]

Could you please open an issue for this improvement and relate this pr to the issue? This will make it clear and easy to tracing.

done. Thank you.

[ctccxxd]

Friendly ping @zroubalik @wozniakjan @SpiritZhou @psi @wonko @fivesheep @JorTurFer hope you to review and discuss, much thanks.

[JorTurFer]

As this can potentially happen before the targetRef is available through the cached client it should check the item using getFromCacheOrDirect to rely on user configuration to try using the direct client

[ctccxxd]

As this can potentially happen before the targetRef is available through the cached client it should check the item using getFromCacheOrDirect to rely on user configuration to try using the direct client

Thank you for your comment. I have follow your idea and change the code already. Hope for your reply soon. MuchThanks.

[JorTurFer]

LGTM! Thanks for the improvement :)

[JorTurFer]

/run-e2e
Update: You can check the progress here

[JorTurFer]

PTAL @kedacore/keda-contributors

[JorTurFer]

@ctccxxd , please open another PR to docs adding the new check to the admission webhooks -> https://github.com/kedacore/keda-docs/blob/main/content/docs/2.17/concepts/admission-webhooks.md

[ctccxxd]

@ctccxxd , please open another PR to docs adding the new check to the admission webhooks -> https://github.com/kedacore/keda-docs/blob/main/content/docs/2.17/concepts/admission-webhooks.md

ok, thank you much

[ctccxxd]

LGTM! Thanks for the improvement :)

Thank you much

[ctccxxd]

@ctccxxd , please open another PR to docs adding the new check to the admission webhooks -> https://github.com/kedacore/keda-docs/blob/main/content/docs/2.17/concepts/admission-webhooks.md

done, kedacore/keda-docs#1506, hope to review. Thank you.

[wozniakjan]

I saw a couple of internal tests fail with message.ScaleTargetNotFoundMsg, we should probably check if the tests are flaky or the error is valid

e.g.

    events_test.go:***: 
        	Error Trace:	/__w/keda/keda/tests/internals/events/events_test.go:***     	            				/__w/keda/keda/tests/internals/events/events_test.go:***59    	            				/__w/keda/keda/tests/internals/events/events_test.go:***97
        	Error:      	Not equal: 
        	            	expected: ""
        	            	actual  : "ScaledObjectCheckFailed:Target resource doesn't exist"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -*** +*** @@
        	            	-
        	            	+ScaledObjectCheckFailed:Target resource doesn't exist

[ctccxxd]

/run-e2e internal

I saw a couple of internal tests fail with message.ScaleTargetNotFoundMsg, we should probably check if the tests are flaky or the error is valid

e.g.

    events_test.go:***: 
        	Error Trace:	/__w/keda/keda/tests/internals/events/events_test.go:***     	            				/__w/keda/keda/tests/internals/events/events_test.go:***59    	            				/__w/keda/keda/tests/internals/events/events_test.go:***97
        	Error:      	Not equal: 
        	            	expected: ""
        	            	actual  : "ScaledObjectCheckFailed:Target resource doesn't exist"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -*** +*** @@
        	            	-
        	            	+ScaledObjectCheckFailed:Target resource doesn't exist

ok, Thank you much

[wozniakjan]

/run-e2e internal
Update: You can check the progress here

[wozniakjan]

looks like there are now more failing tests with these changes

Failed tests:
	Execution of tests/internals/scaled_object_validation/scaled_object_validation_test.go, has failed after "three" attempts
	Execution of tests/internals/events/events_test.go, has failed after "three" attempts
	Execution of tests/internals/cloudevent_source/cloudevent_source_test.go, has failed after "three" attempts

https://github.com/kedacore/keda/actions/runs/12064855537/job/33642776237#step:9:19642

[ctccxxd]

@JorTurFer @zroubalik @wozniakjan hello, I have revise the wrong test cases and test myself. Hope for your review, and e2e test, much thanks.

[ctccxxd]

@zroubalik @JorTurFer @wozniakjan hello, I have revise the wrong test cases and test myself. Hope for your review, and e2e test, much thanks.