Switch external-dns back to official upstream #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytsarev
requested review from
donovanmuller,
k0da,
kuritka,
jkremser and
abaguas
as code owners
ytsarev
changed the title
Fixes k8gb-io#1744 Signed-off-by: Yury Tsarev <[email protected]>
ytsarev
force-pushed
the
external-dns-upstream
branch
from
49dc278 to
150c3f8
Compare
abaguas
reviewed
Nov 2, 2024
There was a problem hiding this comment.
As commented on slack: https://cloud-native.slack.com/archives/C021P656HGB/p1730555833483909?thread_ts=1729982761.336259&cid=C021P656HGB
Version 0.15.0 can't create NS records. ThenewRecordSet function would need to be adapted: https://github.com/kubernetes-sigs/external-dns/blob/master/provider/azure/azure.go#L339
This is the error that we see:
time="2024-11-02T13:52:30Z" level=info msg="Updating NS record named 'cloud' to 'gslb-ns-eu-cloud.k8gb.io;gslb-ns-us-cloud.k8gb.io' for Azure DNS zone 'k8gb.io'."
time="2024-11-02T13:52:30Z" level=error msg="Failed to update NS record named 'cloud' to 'gslb-ns-eu-cloud.k8gb.io;gslb-ns-us-cloud.k8gb.io' for DNS zone 'k8gb.io': unsupported record type 'NS'"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1744
This one needs extensive testing with various edge DNS environments.
The initial local test with rfc2136 is successful.
..
HOW TO RUN CI
---By default, all the checks will be run automatically. Furthermore, when changing website-related stuff, the preview will be generated by the netlify bot.
Heavy tests
Add the
heavy-testslabel on this PR if you want full-blown tests that include more than 2-cluster scenarios.Debug tests
If the test suite is failing for you, you may want to try triggering
Re-run all jobs(top right) with debug logging enabled. It will also make the print debug action more verbose.