Fix ydoc server_settings usage example
#1009
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlqqq
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
@krassowski I'm fine with this change, but not merging this yet since it's still in draft.
Isn't this a bug? If server_settings is a class attribute, then self.server_settings should still resolve to BaseProvider.server_settings. Not sure why it can't be accessed through self here.
|
That's exactly why it is marked as a draft. I needed this change but don't fully understand why and want to explore a little bit before in undrafting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like we need to access it from
BaseProvider, not from self.