Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gmail app password example #107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

softprops
Copy link

@softprops softprops commented Jan 5, 2019

this adds a new example to help illustrate a reproducible case for #106 and an alternative to oauth2 tokens for users of this crate in the future


This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #107 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   78.74%   78.74%           
=======================================
  Files          11       11           
  Lines        1167     1167           
=======================================
  Hits          919      919           
  Misses        248      248

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead7d21...8a43957. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #107 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   78.74%   78.74%           
=======================================
  Files          11       11           
  Lines        1167     1167           
=======================================
  Hits          919      919           
  Misses        248      248

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead7d21...8a43957. Read the comment docs.

@jonhoo
Copy link
Owner

jonhoo commented Jan 6, 2019

Actually, on second thought, this is super similar to the basic.rs example. I think maybe we just want to add a comment about app passwords in basic.rs. Maybe even rename it to gmail.rs + change the server address so it works "out of the box"?

@jonhoo
Copy link
Owner

jonhoo commented Mar 19, 2019

@softprops what do you think of my comment above?

@softprops
Copy link
Author

Im going to go ahead and close this, I was able to unblock myself to testing with another gmail account. feel free to close this

@jonhoo
Copy link
Owner

jonhoo commented Mar 19, 2019

Oh, that's too bad. What problem did you run into?

@softprops
Copy link
Author

This problem #106, something was up with my google account that caused this library to be unable to parse the imap responses. I timeboxed investigating that then ended up just using another gmail account.

@jonhoo
Copy link
Owner

jonhoo commented Mar 19, 2019

Ohh, I remember now. That's too bad — your updated example would be a good addition :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants