Add warning notes if helm charts Istio version is already EOL #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zufardhiyaulhaq <[email protected]>
istio-testing
added
the
size/M
|
cc @howardjohn |
Signed-off-by: zufardhiyaulhaq <[email protected]>
howardjohn
reviewed
Dec 7, 2022
| @@ -160,6 +163,9 @@ type Manifest struct { | |||
| Dependencies IstioDependencies `json:"dependencies"` | |||
| // Version specifies what version of Istio this release is | |||
| Version string `json:"version"` | |||
| // EOLDate specifies what is the date when this Istio version become EOL | |||
| // Should be in format "yyyy-mm" | |||
| EOLDate string `json:"eolDate"` | |||
There was a problem hiding this comment.
If we already have to update istioctl binary directly it seems like we could just update the helm notes directly as well? We can have a test to check they are in sync if needed
Will defer to @ericvn
There was a problem hiding this comment.
do you mean to update the helm notes directly on istio/istio repository?
Signed-off-by: zufardhiyaulhaq <[email protected]>
|
@ericvn can you help here? |
|
cc @istio/wg-test-and-release-maintainers please help review |
istio-testing
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zufardhiyaulhaq [email protected]
fix istio/istio#41747, introduce a warning if the current date is near or after EOL of the date defined in the release builder.