-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conditional noindex meta tag for preliminary and archive #15592
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: milinddethe15 <[email protected]>
Hi @milinddethe15. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@craigbox PTAL |
@craigbox PTAL :) |
layouts/_default/baseof.html
Outdated
{{ if .Site.Data.args.preliminary }} | ||
<meta name="robots" content="noindex"> | ||
{{ else if .Site.Data.args.archive }} | ||
<meta name="robots" content="noindex"> | ||
{{ end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same content, you don't need to include it twice. Use {{ if or }}
(psuedo-template-code!)
Description
#15458
Added noindex meta tag, for preliminary and upcoming archive, by conditional logic in < head > tag of
/layouts/_default/baseof.html
For preliminary.istio.io :: set
.Site.Data.args.preliminary
= trueFor archive.istio.io / in future, when creating snapshot of current version :: set
.Site.Data.args.archive
= trueValue of args are set here:
istio.io/data/args.yml
Lines 19 to 20 in 1a03657
Reviewers