Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional noindex meta tag for preliminary and archive #15592

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

milinddethe15
Copy link
Contributor

Description

#15458

Added noindex meta tag, for preliminary and upcoming archive, by conditional logic in < head > tag of /layouts/_default/baseof.html

For preliminary.istio.io :: set .Site.Data.args.preliminary = true
For archive.istio.io / in future, when creating snapshot of current version :: set .Site.Data.args.archive = true

Value of args are set here:

istio.io/data/args.yml

Lines 19 to 20 in 1a03657

preliminary: true
archive: false

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@milinddethe15 milinddethe15 requested a review from a team as a code owner August 21, 2024 14:18
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Aug 21, 2024
@istio-testing
Copy link
Contributor

Hi @milinddethe15. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Aug 22, 2024
@milinddethe15 milinddethe15 requested a review from Arhell August 30, 2024 07:02
@milinddethe15
Copy link
Contributor Author

@craigbox PTAL

@milinddethe15
Copy link
Contributor Author

@craigbox PTAL :)

Comment on lines 129 to 133
{{ if .Site.Data.args.preliminary }}
<meta name="robots" content="noindex">
{{ else if .Site.Data.args.archive }}
<meta name="robots" content="noindex">
{{ end }}
Copy link
Contributor

@craigbox craigbox Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same content, you don't need to include it twice. Use {{ if or }} (psuedo-template-code!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants