Doc: Add note on DR workloadSelector #3088
+23
−0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -168,6 +168,12 @@ import "type/v1beta1/selector.proto"; | |
| // The following example shows how a destination rule can be applied to a | ||
| // specific workload using the workloadSelector configuration. | ||
| // | ||
| // **Note:** The workloadSelector configuration in | ||
| // destination rule controls which client workloads | ||
| // use this destination rule, rather than which server workloads do. | ||
| // [Subsets](https://istio.io/latest/docs/reference/config/networking/destination-rule/#Subset) | ||
| // can be used to select server workloads in fine granularity. | ||
|
There was a problem hiding this comment. I don't think this is accurate. Subsets control load balancing on the clinet-side, it doesn't impact which servers implemnent which policies. https://github.com/istio/istio/blob/388d5d1b9f37e7c3d15cf72967fad22f0b8e70fb/pilot/pkg/networking/core/v1alpha3/cluster_builder.go#L380 - no subset involved. There was a problem hiding this comment. Subsets are used to control which servers the traffic is routed to. I'll improve the wording here to eliminate ambiguity. |
||
| // | ||
| // {{<tabset category-name="selector-example">}} | ||
| // {{<tab name="v1alpha3" category-value="v1alpha3">}} | ||
| // ```yaml | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/istio/istio/blob/388d5d1b9f37e7c3d15cf72967fad22f0b8e70fb/pilot/pkg/networking/core/v1alpha3/cluster_builder.go#L380 - SidecarScope.DestinationRule does control the server workloads?