Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pause receiving while submitting tasks #534

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

minrk
Copy link
Member

@minrk minrk commented Jul 19, 2021

results coming in during submission causes thread contention while submitting tasks, which can thrash performance with context switches

This pauses receiving messages while we are preparing tasks to be submitted, and resumes when they are done submitting. The result is the client focusing on task submission, delaying handling of results until it is done sending.

Need to do some testing, but prior to this PR, I could create a task pipeline that looks like this:

bubble

where a 'bubble' was created as the main task-creation thread paused while receiving the first bunch of tasks before submitting the next batch. This is hard to reproduce because it's thread contention with async network events, but I can at least compare overall execution time.

whereas a similar computation with this PR is denser:

image

I need to do some more tests and visualization to make better comparisons.

Also working on adding a notebook to the docs for visualizing an asyncresult's timestamps for profiling, etc. which is how I created these graphs.

@minrk minrk force-pushed the bubbles-and-locks branch from bc9c32e to a98a4fa Compare July 19, 2021 08:52
@minrk
Copy link
Member Author

minrk commented Jul 21, 2021

Run again with 480 engines, 20 tasks/engine (top is main, 3093386 , bottom is this pr, a98a4fa). Workload is load-balanced submission of random 0-1s tasks (same seed), 20 tasks/engine for a total of 9600 tasks.

Screen Shot 2021-07-21 at 14 25 20

Can see that while the client is working to produce the tasks, there is still contention between serializing in the main thread and actually sending in the io thread until the main thread is done (purple line). This completes 1s faster in this PR (7.6s vs 8.4s). The first result doesn't arrive for 2 more seconds, which is really around when the last real send completes and receives start being processed.

The bubble can be seen around 11s in main, which is where sends and receives are both being processed, and this is gone after this PR.

@minrk
Copy link
Member Author

minrk commented Aug 4, 2021

The failure on Windows appears to be a reliably reproducible one, which makes me think I've introduced some possible inconsistent state when pausing/unpausing handlers (windows CI is typically much slower than others, so it tends to have different behavior when there are race conditions).

@minrk minrk force-pushed the bubbles-and-locks branch 2 times, most recently from b5bbcf5 to 6fd74c7 Compare August 10, 2021 11:41
minrk added 2 commits August 11, 2021 13:53
results coming in during submission causes thread contention while submitting tasks

pause receiving messages while we are preparing tasks to be submitted
empty maps never worked with block=False, which was never tested!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant