Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Comm rather than BaseComm from create_comm #1091

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Return Comm rather than BaseComm from create_comm #1091

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b28f36
Return Comm rather than BaseComm from create_comm
matthewturk Feb 8, 2023
2587d8a
lint
blink1073 Feb 8, 2023
66d91f7
Merge branch 'main' into issue1090
blink1073 Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ipykernel/ipkernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from traitlets import Any, Bool, HasTraits, Instance, List, Type, observe, observe_compat
from zmq.eventloop.zmqstream import ZMQStream

from .comm.comm import BaseComm
from .comm.comm import Comm
from .comm.manager import CommManager
from .compiler import XCachingCompiler
from .debugger import Debugger, _is_debugpy_available
Expand Down Expand Up @@ -45,7 +45,7 @@

def _create_comm(*args, **kwargs):
"""Create a new Comm."""
return BaseComm(*args, **kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I misunderstood what you intended to change. We wanted to explicitly return BaseComm here because it is more efficient. I think the right answer is for ipywidgets to relax its expected trait.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, BaseComm is 'the new thing', Comm is for backwards compatibility with ipywidgets.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, but since ipywidgets doesn't accept BaseComm should that be the submitted change? I guess I'm confused because @blink1073's suggestion seemed straightforward, but now I don't understand how to interpret @maartenbreddels's reply.

return Comm(*args, **kwargs)


# there can only be one comm manager in a ipykernel process
Expand Down