Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types and publish dev releases #49

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Fix types and publish dev releases #49

wants to merge 21 commits into from

Conversation

cabljac
Copy link
Contributor

@cabljac cabljac commented Jun 27, 2022

This PR fixes some type errors in the firestore hooks, and bumps up the versions of packages to the dev releases

@cabljac cabljac requested a review from Ehesp June 27, 2022 11:43
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #49 (595cfa8) into main (0acc863) will increase coverage by 1.55%.
The diff coverage is 71.68%.

❗ Current head 595cfa8 differs from pull request most recent head 45b562b. Consider uploading reports for the commit 45b562b to get more accurate results

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   59.73%   61.29%   +1.55%     
==========================================
  Files          22       22              
  Lines         457      509      +52     
  Branches       44       72      +28     
==========================================
+ Hits          273      312      +39     
- Misses        184      197      +13     
Impacted Files Coverage Δ
packages/auth/src/useAuthIdToken.ts 100.00% <ø> (ø)
packages/auth/src/useAuthUser.ts 100.00% <ø> (ø)
packages/firestore/src/useFirestoreQueryData.ts 50.00% <30.00%> (+2.00%) ⬆️
packages/firestore/src/useFirestoreDocumentData.ts 51.72% <33.33%> (-0.91%) ⬇️
packages/firestore/src/useFirestoreQuery.ts 90.90% <86.66%> (-9.10%) ⬇️
packages/firestore/src/useFirestoreDocument.ts 94.44% <92.30%> (-5.56%) ⬇️
packages/utils/src/useSubscription.ts 92.18% <93.61%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0acc863...45b562b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants