-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace to emplace C++11 for code refactor and minor optimize inserts #1875
base: master
Are you sure you want to change the base?
Conversation
media_softlet/agnostic/common/vp/hal/features/vp_hdr_filter.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls fix the compilation error
fix it c95e85f |
Thanks for your patching. |
@MicroYY reserve vector optimization insert: #1869 And there is also very good optimization classes and structures that are often moved and copied, optimization affects all modern x64 processors. align for x64 cpu: #1873 |
@MicroYY maybe I split commit into many commits? Code review takes a long time. |
Rather, it refers more to refactoring and code reduction, I checked assembly listing -O0 and -O2 on clang. And it also affects optimization insert on Release configuration.
Clang 19 emplace -O0
Clang 19 emplace -O2
VS
Clang 19 insert make_pair -O0
Clang 19 insert make_pair -O2