-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade devcontainer setup #14419
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, I've been wanting a setup like it for a long time. Thank you very much!
Can you also add some instructions to the developer documentation on how to use this?
@mcarbonne since you added the original devcontainer bits, do you have any feedback on this PR?
"initializeCommand": "bash .devcontainer/scripts/initializeCommand.sh", | ||
"onCreateCommand": "bash .devcontainer/scripts/onCreateCommand.sh", | ||
"overrideCommand": true, | ||
"workspaceFolder": "/immich", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for compatibility with github codespaces this needs to be /workspaces/immich
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it, seems not to be a requirement.
When running this in codespaces I get the following error
which suggests that codespaces is running an outdated docker version, but I can't figure out which version or why. Of course this can be 'fixed' by removing the healthcheck, but I'd rather it run an up to date docker engine. Do you have any insight into that? |
8dc3103
to
64cfb2a
Compare
I focused the devcontainer on local development, didn't test with codespaces until now since I'm not using it at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The devcontainer setup looks good, thank you! Can you add some instructions on how to use it to the docs at https://immich.app/docs/developer/setup? After that this'll be ready to merge imo :)
The instruction to set the settings is not necessary anymore I guess since those are now set in https://github.com/immich-app/immich/blob/main/.vscode/settings.json Should the current instructions for installing extensions be left in there as a second option to set the environment up manually? |
Upgrades the devcontainer implementation with the following changes:
To start the immich docker containers there must be an .env file available but I didn't like failing the start of the devcontainer. Instead if the .env file isn't found under the .devcontainer folder it will copy the example.env from the docker folder and use that instead. Unfortunately the .env file must be existing in the .devcontainer folder - I couldn't find a way to use the .env file from the docker folder.