Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply suggested workaround for affected CI test #553

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Dec 12, 2024

This PR tries to implement the workaround identified in actions/runner-images#11137 for the CI failure on Ubuntu 24.04 with Python 3.12.
I'm not sure which part(s) of the suggested workaround are actually required, some seem to evaluate to no-ops (e.g. libssl-dev is already the newest version (3.0.2-0ubuntu1.18).). I'll play around with the steps to see if the workaround can be made more concise.

How to review

  • Read the diff and note that the CI checks all pass (in particular the one on ubuntu-latest-py3.12).

PR checklist

  • Continuous integration checks all ✅
  • Update tests; coverage checks both ✅
  • [ ] Add, expand, or update documentation. Just CI.
  • [ ] Update release notes. Just CI.

@glatterf42 glatterf42 added the ci Continuous integration label Dec 12, 2024
@glatterf42 glatterf42 self-assigned this Dec 12, 2024
@glatterf42 glatterf42 force-pushed the fix/ubuntu-tutorials-r-jupyter branch from c73618f to 32a862c Compare December 12, 2024 10:12
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.8%. Comparing base (02dadfa) to head (d93ed2a).

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #553     +/-   ##
=======================================
- Coverage   98.9%   98.8%   -0.2%     
=======================================
  Files         44      44             
  Lines       4790    4790             
=======================================
- Hits        4740    4734      -6     
- Misses        50      56      +6     

see 3 files with indirect coverage changes

@glatterf42 glatterf42 force-pushed the fix/ubuntu-tutorials-r-jupyter branch 6 times, most recently from 5a0cf10 to 813b7a4 Compare December 12, 2024 10:50
@glatterf42 glatterf42 force-pushed the fix/ubuntu-tutorials-r-jupyter branch 2 times, most recently from 7272227 to 6e7a5fe Compare December 12, 2024 14:14
@glatterf42 glatterf42 force-pushed the fix/ubuntu-tutorials-r-jupyter branch from 6e7a5fe to d93ed2a Compare December 13, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant