forked from istio/client-go
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes istio/api#3019 The deepcopygen we use is from Kubernetes. Its not quite suitable for our types due to our usage of protobuf, which has limitations on dereferencing pointer types. This causes race conditions in concurrent usage of the DeepCopy function. This is possible to trigger with real Istio (found by running Istio in a live cluster with `-race`, though our current tests happen to not trigger things I guess), as well as other usage of istio/client-go (as the reporter found). I ran istio/istio with this change and found all tests continue to pass, and running in a live cluster no longer fails
- Loading branch information
1 parent
6bad57d
commit 830bc1c
Showing
9 changed files
with
7 additions
and
64 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.