Show logbook component in more info for non-numeric values #22997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, this way does not always work as expected: loads on some sensors endless till i open the logbook: |
karwosts
reviewed
Nov 26, 2024
| @@ -111,7 +112,8 @@ export const computeShowLogBookComponent = ( | |||
|
|
|||
| const domain = computeDomain(entityId); | |||
| if ( | |||
| CONTINUOUS_DOMAINS.includes(domain) || | |||
| (CONTINUOUS_DOMAINS.includes(domain) && | |||
| isNumericEntity(domain, stateObj, undefined, [], false)) || | |||
There was a problem hiding this comment.
I think ideally we'd like to also use the numericDevicesClasses cached list here, instead of just passing an empty array.
It is slightly tricky though as getting that is an async operation, so you'll have to probably do it at the caller and pass it into this function.
MindFreeze
reviewed
Dec 5, 2024
| @@ -111,7 +112,8 @@ export const computeShowLogBookComponent = ( | |||
|
|
|||
There was a problem hiding this comment.
There is a check for stateObj.attributes.unit_of_measurement a couple of lines up that would become redundant and should be removed as isNumericFromAttributes already checks that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
this is a fix for another already closed pull request:
Show logbook in more-info for non-numeric values:
Tried to export and use isNumeric from frontend/src/data/history.ts as suggested in #22762
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: