Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Freebox to 1.2.1 #133455

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Bump Freebox to 1.2.1 #133455

merged 4 commits into from
Dec 19, 2024

Conversation

Quentame
Copy link
Member

@Quentame Quentame commented Dec 17, 2024

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @hacf-fr, mind taking a look at this pull request as it has been labeled with an integration (freebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of freebox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign freebox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@cdce8p
Copy link
Member

cdce8p commented Dec 18, 2024

You can fix the mypy issue by wrapping token_file with str here (i.e. str(token_file)):

return Freepybox(APP_DESC, token_file, API_VERSION)

The alternative would be to accept Path for token_file in Freepybox as well. From the looks of it, it should be compatible. The Path is only passed to open with read and write.

@Quentame
Copy link
Member Author

Quentame commented Dec 18, 2024

You can fix the mypy issue by wrapping token_file with str here (i.e. str(token_file)):

return Freepybox(APP_DESC, token_file, API_VERSION)

The alternative would be to accept Path for token_file in Freepybox as well. From the looks of it, it should be compatible. The Path is only passed to open with read and write.

That should work too right ? 20cbcd7

Also adding Path type to the dependency

@joostlek
Copy link
Member

Tests are failing now

This reverts commit 20cbcd7.
@Quentame Quentame changed the title Bump Freebox to 1.2.0 Bump Freebox to 1.2.1 Dec 19, 2024
@Quentame Quentame marked this pull request as ready for review December 19, 2024 22:14
@Quentame Quentame requested a review from joostlek December 19, 2024 22:54
@joostlek joostlek merged commit 64aba0c into home-assistant:dev Dec 19, 2024
65 checks passed
@Quentame Quentame deleted the freebox/bump branch December 20, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Freebox integration is no longer working due to SSLCertVerificationError
3 participants