-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to official Zabbix Python API #131674
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
2ff74b1
to
b3de07c
Compare
aba11eb
to
b2dbac8
Compare
Starightforward 1-to-1 migration. LGTM 👍 |
Sanity check of Does the current integration support Zabbix < 5? If yes, we need to add a breaking change section to this PR |
Good call. According to an archived copy of their release policy, Zabbix 4.x stopped receiving full support in Oct. 2021 and limited support in Oct. 2023. I imagine that means the impact for this breaking change will be almost zero. Is there any special format needed to indicate a breaking change in the description that gets rolled into release notes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the CI
Tagging it with |
Done. |
fc6034f
to
247f161
Compare
The Zabbix project released an official Python API library called "zabbix_utils" which can replace the current library that this component is using. This just does a conversion to the existing synchronous API. The new Python library also supports an asynchronous API which could be used to further migrate this plugin.
247f161
to
e541dd4
Compare
Looks like there was an existing mypy error on another module. Merged in latest 'dev' to hopefully avoid that. |
Breaking change
This change drops support for Zabbix 4 and before. Only Zabbix 5+ versions are supported.
Proposed change
Currently the Zabbix component is broken with Zabbix 5.4 or newer, because the API changed to require "username" instead of "user" to login at that point.
The Zabbix project released an official Python API library called "zabbix_utils" which can replace the current library that this component is using.
This just does a conversion to the existing synchronous API. The new Python library also supports an asynchronous API which could be used to further migrate this plugin.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: