Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compit core integration #6098

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Przemko92
Copy link
Contributor

@Przemko92 Przemko92 commented Nov 13, 2024

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing a reference to the pull request in our core repository, could you add it?

./Klaas

@home-assistant home-assistant bot marked this pull request as draft November 13, 2024 12:55
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@frenck
Copy link
Member

frenck commented Dec 2, 2024

Since there was no response at all, I'm declaring this PR stale and closing it.
Feel free to re-open this PR when you feel like that is the appropriate thing to do.

@Przemko92
Copy link
Contributor Author

@frenck I've updated my PR. Can you please reopen it?

@klaasnicolaas klaasnicolaas reopened this Dec 3, 2024
@Przemko92 Przemko92 marked this pull request as ready for review December 3, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants