-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added logos and icon for Vegetronix VegeHub #6047
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds branding for a core integration, however, there is no Pull Request to our Core codebase linked up in this PR. Could you please point me to it?
Thanks! 👍
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sorry, I'm new to all of this and I'm still learning the ropes. I've added the link in the PR in question. My PR for the Core is still a work in progress, but I wasn't sure what order to do everything in, so I submitted logos/icons first. If those should be submitted later in the process, I'd be happy to retract my PR here until the integration is accepted into the Core. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved. Can be merged as soon as the parent PR gets merged.
Proposed change
I work for a company called Vegetronix. We want to add official support for connecting our VegeHub product to Home Assistant. I am almost finished with development of the integration, and I wanted to add logos and an icon to the HA brands so that I could link to them in the integration. I think I followed all guidelines, but please let me know if there's anything I need to change. Thanks!
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)[email protected]
)logo.png
)[email protected]
)