Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup-sbt Action #51

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Add setup-sbt Action #51

merged 1 commit into from
Dec 10, 2024

Conversation

JamieB-gu
Copy link
Contributor

Installs sbt. We need this because GitHub no longer includes sbt in its base images, so we have to set it up separately.

We can't use guardian/setup-scala because this mandates caching of sbt resources, which slows down builds in this workflow as seen in 137fd0a due to actions/setup-java#564

Paired with @rtyley

Installs `sbt`. We need this because GitHub no longer includes `sbt` in its base images, so we have to set it up separately.

We can't use `guardian/setup-scala` because this mandates caching of `sbt` resources, which slows down builds in this workflow as seen in 137fd0a due to actions/setup-java#564
@JamieB-gu JamieB-gu requested a review from rtyley December 10, 2024 17:01
Copy link
Member

@rtyley rtyley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've verified that this worked with guardian/fastly-api-client#58 - looks good!

@rtyley rtyley merged commit 1cb253e into main Dec 10, 2024
@JamieB-gu JamieB-gu deleted the add-setup-sbt-action branch December 10, 2024 17:28
@rtyley
Copy link
Member

rtyley commented Dec 11, 2024

I've released this as v1.0.1 of the workflow, updating the v1 tag to point to that latest version. Users of gha-scala-library-release-workflow should probably be pointing to v1 rather than main, but right now the issue isn't very pressing - only will be become important when we break compatiblity! See also:

sageserpent-open added a commit to sageserpent-open/americium that referenced this pull request Dec 11, 2024
…make sure the publishing action works correctly on GitHub.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants