Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added get_cell_weights to DomainContributions.jl #909

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hammy4815
Copy link

See #907 .

This PR adds the get_cell_weights() methods required to access lower level access to quadrature points.

@amartinhuertas amartinhuertas requested a review from fverdugo July 12, 2023 22:01
@amartinhuertas
Copy link
Member

hi @hammy4815 ! Thanks for the PR. It turns out that the tests failed in Github actions. Can you please run Gridap tests locally and see if the problem reproduces in your local environment? If yes, can you please fix it and push? Thanks!

@hammy4815
Copy link
Author

hammy4815 commented Jul 15, 2023

hi @hammy4815 ! Thanks for the PR. It turns out that the tests failed in Github actions. Can you please run Gridap tests locally and see if the problem reproduces in your local environment? If yes, can you please fix it and push? Thanks!

I had accidentally kept internal calls to Gridap types and functions such as Gridap.CellData.CellQuadrature rather than just CellQuadrature and a few other examples. They should be removed now.

@amartinhuertas
Copy link
Member

I had accidentally kept internal calls to Gridap types and functions such as Gridap.CellData.CellQuadrature rather than just CellQuadrature and a few other examples. They should be removed now.

No worries. Can you please add the corresponding entry in NEWS.md file? Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #909 (e9303fc) into master (94419b8) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
- Coverage   88.50%   88.47%   -0.03%     
==========================================
  Files         172      172              
  Lines       20121    20121              
==========================================
- Hits        17808    17802       -6     
- Misses       2313     2319       +6     
Impacted Files Coverage Δ
src/CellData/DomainContributions.jl 79.20% <0.00%> (-12.75%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants