-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Learn introduction page. #1799
Conversation
@mandiwise is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, some really good improvements here! I've made some suggested edits where I felt there was some potential ambiguity in the wording in a couple places, or where the copy could be tightened up slightly; let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! 🤩
I've applied some minor edits; I'll leave this open for a few days to see if there's any other feedback but I think it's good to merge - thanks for your work on this, it's a great improvement in my opinion! |
@apply border-neutral-200; | ||
@apply border-b; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
GraphQL is a query language for your API, and a server-side runtime for executing queries using a type system you define for your | ||
data. GraphQL isn't tied to any specific database or storage engine and is instead backed by your existing code and data. | ||
<Callout type="info">If you're already familiar with GraphQL and would like to read documentation on how to build a GraphQL service, then there are libraries to help you implement GraphQL in [many different languages](/community/tools-and-libraries/?tags=server). There are also many libraries available that allow [client applications to query existing GraphQL APIs](/community/tools-and-libraries/?tags=client).</Callout> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention about GraphQL.js being the official reference implementation maintained by the GraphQL foundation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benjie Do you want to call out graphql.js specifically here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to do that here, but our first mention of a "reference implementation" should hyperlink to GraphQL.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks amazing!
Excellent work @mandiwise and great feedback everyone 🙌 |
Co-authored-by: Benjie <[email protected]>
Addresses #1112 and #1698
Description
This PR contains revised content of for the Introduction page of the Learn section.
@jorydotcom @benjie