Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Learn introduction page. #1799

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Conversation

mandiwise
Copy link
Contributor

Addresses #1112 and #1698

Description

This PR contains revised content of for the Introduction page of the Learn section.

@jorydotcom @benjie

Copy link

vercel bot commented Oct 20, 2024

@mandiwise is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 4:49pm

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, some really good improvements here! I've made some suggested edits where I felt there was some potential ambiguity in the wording in a couple places, or where the copy could be tightened up slightly; let me know what you think.

src/pages/learn/index.mdx Outdated Show resolved Hide resolved
src/pages/learn/index.mdx Outdated Show resolved Hide resolved
src/pages/learn/index.mdx Outdated Show resolved Hide resolved
src/pages/learn/index.mdx Outdated Show resolved Hide resolved
src/pages/learn/index.mdx Outdated Show resolved Hide resolved
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 🤩

src/pages/learn/index.mdx Outdated Show resolved Hide resolved
src/pages/learn/index.mdx Outdated Show resolved Hide resolved
src/pages/learn/index.mdx Outdated Show resolved Hide resolved
src/pages/learn/index.mdx Outdated Show resolved Hide resolved
@benjie
Copy link
Member

benjie commented Oct 24, 2024

I've applied some minor edits; I'll leave this open for a few days to see if there's any other feedback but I think it's good to merge - thanks for your work on this, it's a great improvement in my opinion!

Comment on lines +493 to +494
@apply border-neutral-200;
@apply border-b;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

border color should be improved on dark mode
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Border color for dark mode has been adjusted.

Screenshot 2024-10-29 at 2 51 01 PM


GraphQL is a query language for your API, and a server-side runtime for executing queries using a type system you define for your
data. GraphQL isn't tied to any specific database or storage engine and is instead backed by your existing code and data.
<Callout type="info">If you're already familiar with GraphQL and would like to read documentation on how to build a GraphQL service, then there are libraries to help you implement GraphQL in [many different languages](/community/tools-and-libraries/?tags=server). There are also many libraries available that allow [client applications to query existing GraphQL APIs](/community/tools-and-libraries/?tags=client).</Callout>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention about GraphQL.js being the official reference implementation maintained by the GraphQL foundation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjie Do you want to call out graphql.js specifically here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to do that here, but our first mention of a "reference implementation" should hyperlink to GraphQL.js

Copy link
Member

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks amazing!

@benjie benjie merged commit f7bfbd1 into graphql:source Oct 31, 2024
2 of 3 checks passed
@benjie
Copy link
Member

benjie commented Oct 31, 2024

Excellent work @mandiwise and great feedback everyone 🙌

mandiwise added a commit to mandiwise/graphql.github.io that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants