Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) MemoizingSupplier.isMemoized #7450

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexey-pelykh
Copy link

Addresses #7292

@alexey-pelykh alexey-pelykh force-pushed the feat/MemoizingSupplier-isInitialized branch 3 times, most recently from 84f2644 to f830a5e Compare October 17, 2024 08:53
@alexey-pelykh alexey-pelykh force-pushed the feat/MemoizingSupplier-isInitialized branch 2 times, most recently from cc27f03 to 5ff8e10 Compare October 21, 2024 07:13
@alexey-pelykh alexey-pelykh marked this pull request as ready for review October 21, 2024 07:15
@alexey-pelykh
Copy link
Author

alexey-pelykh commented Oct 21, 2024

I'm having some issues with verification locally:

[ERROR] Errors: 
[ERROR]   GcFinalizationTest.testAwaitClear_interrupted:185->assertWrapsInterruptedException:150 » NoClassDefFound Could not initialize class com.google.common.truth.Platform
[ERROR]   GcFinalizationTest.testAwaitDone_finalizationPredicate_interrupted:206->assertWrapsInterruptedException:150 » NoClassDefFound Could not initialize class com.google.common.truth.Platform
[ERROR]   GcFinalizationTest.testAwaitDone_future_interrupted_interrupted:172->assertWrapsInterruptedException:150 » NoSuchMethod 'com.google.common.base.Supplier com.google.common.base.Suppliers.memoize(com.google.common.base.Supplier)'
[ERROR]   GcFinalizationTest.testAwait_countDownLatch_interrupted:159->assertWrapsInterruptedException:150 » NoClassDefFound Could not initialize class com.google.common.truth.Platform

And apparently I'm unable to find the root of that thus far

@alexey-pelykh alexey-pelykh force-pushed the feat/MemoizingSupplier-isInitialized branch from 5ff8e10 to 3897edd Compare October 21, 2024 07:35
@alexey-pelykh
Copy link
Author

The following line

assertThat(ex).hasCauseThat().isInstanceOf(NotSerializableException.class);

in SuppliersTest.java@152 seems to cause

java.lang.NoSuchMethodError: 'com.google.common.base.Supplier com.google.common.base.Suppliers.memoize(com.google.common.base.Supplier)'

yet debugging shows that it should be just fine:

Screenshot 2024-10-21 at 09 38 04

I am puzzled 🤔

@alexey-pelykh alexey-pelykh force-pushed the feat/MemoizingSupplier-isInitialized branch 2 times, most recently from bb13e7a to 24ddf32 Compare October 21, 2024 07:56
@alexey-pelykh alexey-pelykh changed the title (feat) MemoizingSupplier.isInitialized (feat) MemoizingSupplier.isMemoized Oct 21, 2024
@alexey-pelykh alexey-pelykh force-pushed the feat/MemoizingSupplier-isInitialized branch 2 times, most recently from 2f12af6 to b0ca1fe Compare October 27, 2024 19:08
@alexey-pelykh alexey-pelykh force-pushed the feat/MemoizingSupplier-isInitialized branch from b0ca1fe to 7536652 Compare November 27, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants